Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-fetch@^6.0.0 #1705

Closed
theseyi opened this issue Oct 31, 2018 · 5 comments
Closed

ember-fetch@^6.0.0 #1705

theseyi opened this issue Oct 31, 2018 · 5 comments

Comments

@theseyi
Copy link

theseyi commented Oct 31, 2018

ember-fetch@^6.0.0 has been released, ember-simple-auth should upgrade to and/or support this version:

"dependencies": {
  "ember-fetch": "^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0",
}

should be:

"dependencies": {
  "ember-fetch": "^2.1.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0",
}
@marcoow
Copy link
Member

marcoow commented Nov 9, 2018

Can you submit a PR?

@andreyfel
Copy link
Contributor

This blocks upgrading projects with mono-repo to ember-cli 3.5 because of the bug fixed in ember-fetch 6.1.1.

@lougreenwood
Copy link

I also had an issue when using latest ember-fetch with prember & ember-simple-auth:

ember-cli/ember-fetch#166

@andreyfel
Copy link
Contributor

Created pr #1713 to address that issue.

@andreyfel
Copy link
Contributor

@mike-north is it possible to release a new version of ember-simple-auth with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants