From 49210ebe8993b8b53538d0aab0be3fa97fe8deaa Mon Sep 17 00:00:00 2001
From: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Date: Fri, 1 Oct 2021 00:00:47 +0300
Subject: [PATCH] Test that the root CA chain is working for the http_client
 dependencies

---
 spec/omniauth/strategies/tunnistamo_spec.rb | 30 +++++++++++++++++++++
 spec/spec_helper.rb                         |  5 +++-
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/spec/omniauth/strategies/tunnistamo_spec.rb b/spec/omniauth/strategies/tunnistamo_spec.rb
index e89128d..51b9e08 100644
--- a/spec/omniauth/strategies/tunnistamo_spec.rb
+++ b/spec/omniauth/strategies/tunnistamo_spec.rb
@@ -50,6 +50,36 @@
     ), headers: {})
   end
 
+  # Dependencies using the http_client gem need to be configured properly in
+  # order for them to use the correct root certificate chain. Otherwise it would
+  # use the chain shipped with the http_client gem instead which would cause
+  # expiry or missing issuer certificate errors for Let's Encrypt certificates.
+  #
+  # certificate verify failed (unable to get local issuer certificate)
+  # certificate verify failed (certificate has expired)
+  #
+  # For more information, see:
+  # https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
+  #
+  # And the relevant lines in the http_client gem:
+  # https://github.com/nahi/httpclient/blob/4658227a46f7caa633ef8036f073bbd1f0a955a2/lib/httpclient/ssl_config.rb#L426-L429
+  describe 'valid root certificates for http_client dependencies' do
+    subject { described_class.new(app, strategy_options) }
+
+    # The config method needs to be called for the HTTPClient configuratios to
+    # apply.
+    before { subject.config }
+
+    [SWD, WebFinger, OpenIDConnect].each do |dependency|
+      it "connects successfully with #{dependency.name}" do
+        expect do
+          # Fetch any domain using the Let's encrypt certificate
+          dependency.http_client.get_content('https://acme-v02.api.letsencrypt.org/directory')
+        end.not_to raise_error
+      end
+    end
+  end
+
   describe 'GET /auth/tunnistamo' do
     subject { get '/auth/tunnistamo' }
 
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 47487b2..926be31 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -17,7 +17,10 @@
 OmniAuth.config.logger = TEST_LOGGER
 OmniAuth.config.full_host = 'https://www.service.fi'
 
-WebMock.disable_net_connect!(allow_localhost: true)
+WebMock.disable_net_connect!(
+  allow_localhost: true,
+  allow: 'acme-v02.api.letsencrypt.org'
+)
 
 RSpec.configure do |config|
   config.include Rack::Test::Methods