Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antd tab close button too BIG #492

Closed
joshuef opened this issue Dec 20, 2018 · 2 comments · Fixed by #700
Closed

Antd tab close button too BIG #492

joshuef opened this issue Dec 20, 2018 · 2 comments · Fixed by #700
Labels
Milestone

Comments

@joshuef
Copy link
Collaborator

joshuef commented Dec 20, 2018

Looking at the two buttons for closing / opening tabs, the close button seems sooooo big.

Like, too big.

https://www.dropbox.com/s/m07e0lfzygjsocd/Screenshot%202018-12-20%2009.43.28.jpg?dl=0

Comparing that to chrome (https://www.dropbox.com/s/hy2jz6deh447v1j/Screenshot%202018-12-20%2009.46.40.jpg?dl=0), you can see that the close button is just a bit smaller.

@shriram2301 I think we should remove the 'button' aspect of this 'close' button, and use only the icon, and then make that icon, a bit smaller.

Note, the icon should still have a pointer on hover, and ideally some :hover css state to reflect this interact-ablity (as well as the click event/functionality).

@joshuef joshuef added this to the next milestone Dec 20, 2018
@joshuef joshuef modified the milestones: 0.11.1, Next Jan 17, 2019
@joshuef joshuef mentioned this issue Apr 10, 2019
2 tasks
@joshuef joshuef added 0.13.0 and removed blocked labels Apr 11, 2019
@joshuef joshuef added blocked and removed 0.13.0 labels Apr 22, 2019
@joshuef
Copy link
Collaborator Author

joshuef commented Apr 22, 2019

Just to note, this is currently tied to #669

@safesurfer
Copy link
Contributor

QA verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants