Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Flutter 3.27.0 compatibility #195

Closed
gruuna opened this issue Dec 12, 2024 · 3 comments
Closed

Flutter Flutter 3.27.0 compatibility #195

gruuna opened this issue Dec 12, 2024 · 3 comments
Labels
bug Something isn't working fixed The issue is fixed in new release P1 High Priority: This is a show stopper and must be addressed immediately

Comments

@gruuna
Copy link

gruuna commented Dec 12, 2024

The bug

With the newly released version of Flutter I get the following error trying to compile our app:

searchfield-1.2.0/lib/src/input_decoration.dart:128:25: Error: The method 'SearchInputDecoration.copyWith' doesn't have the named parameter 'maintainHintHeight' of overridden method 'InputDecoration.copyWith'. SearchInputDecoration copyWith({ ^ ../../../flutter/packages/flutter/lib/src/material/input_decorator.dart:3597:19: Context: This is the overridden method ('copyWith'). InputDecoration copyWith({ ^

Seems like the copyWith method does not fit to InputDecoration of Flutter material anymore...

@maheshj01 maheshj01 added in triage Issue is currently being triaged P1 High Priority: This is a show stopper and must be addressed immediately bug Something isn't working and removed in triage Issue is currently being triaged labels Dec 12, 2024
@maheshj01
Copy link
Owner

Hi @gruuna, Thanks for filing the issue. Will take a look at it asap.

@maheshj01
Copy link
Owner

@gruuna Published a new release v1.2.1 Thank you for bring this up quick. Issues like these help searchfield keep up with flutter releases.

@maheshj01 maheshj01 added the fixed The issue is fixed in new release label Dec 12, 2024
@furkanKotic
Copy link

I think this fix broke compatibility with older versions of Flutter. @maheshj01

Target dart2js failed: ProcessException: Process exited abnormally with exit code 1:
../../../../AppData/Local/Pub/Cache/hosted/pub.dev/searchfield-1.2.1/lib/src/input_decoration.dart:62:3:
Error: The superclass, 'InputDecoration', has no unnamed constructor that takes no arguments.
  SearchInputDecoration({
  ^^^^^^^^^^^^^^^^^^^^^
../../../../AppData/Local/Pub/Cache/hosted/pub.dev/searchfield-1.2.1/lib/src/input_decoration.dart:196:54:
Error: The getter 'maintainHintHeight' isn't defined for the class 'SearchInputDecoration'.
 - 'SearchInputDecoration' is from 'package:searchfield/src/input_decoration.dart' ('../../../../AppData/Local/Pub/Cache/hosted/pub.dev/searchfield-1.2.1/lib/src/input_decoration.dart').
      maintainHintHeight: maintainHintHeight ?? this.maintainHintHeight,
                                                     ^^^^^^^^^^^^^^^^^^
Error: Compilation failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed The issue is fixed in new release P1 High Priority: This is a show stopper and must be addressed immediately
Projects
None yet
Development

No branches or pull requests

3 participants