Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts don't work in chrome/ubuntu #15

Closed
SinaKarimi7 opened this issue Apr 5, 2021 · 10 comments · Fixed by #18
Closed

Shortcuts don't work in chrome/ubuntu #15

SinaKarimi7 opened this issue Apr 5, 2021 · 10 comments · Fixed by #18
Assignees
Labels
bug Something isn't working

Comments

@SinaKarimi7
Copy link

SinaKarimi7 commented Apr 5, 2021

Nothing happens when pressing Ctrl + Shift + S.

image

@SinaKarimi7 SinaKarimi7 changed the title Shortcuts doesn Shortcuts don't work in chrome/ubuntu Apr 5, 2021
@mahdyar mahdyar added the bug Something isn't working label Apr 5, 2021
@mahdyar
Copy link
Owner

mahdyar commented Apr 5, 2021

Hello @SinaKarimi7 and thank you for your report,
Would you let me know what desktop environment are you using?

Update:
I've tried on Ubuntu with Gnome, and Chrome/Chromium, it works just fine:

Screenshot from 2021-04-05 17-54-48
Screenshot from 2021-04-05 17-58-56-2

@mahdyar mahdyar removed the bug Something isn't working label Apr 5, 2021
@mahdyar
Copy link
Owner

mahdyar commented Apr 9, 2021

@SinaKarimi7 Is the problem solved? If not, please let me know what desktop environment are you using?

@SinaKarimi7
Copy link
Author

SinaKarimi7 commented Apr 11, 2021

@mahdyar Thank you for your response. But it still doesn't work for me and nothing happens by hitting the shortcuts.
How do I know what is happening?


OS: Ubuntu 18.04.5 LTS x86_64 
Kernel: 5.11.11-051111-generic
DE: GNOME 3.28.4 
BR: Google Chrome Version 89.0.4389.114 (Official Build) (64-bit)

@mahdyar
Copy link
Owner

mahdyar commented Apr 11, 2021

@mahdyar Thank you for your response. But it still doesn't work for me and nothing happens by hitting the shortcuts.
How do I know what is happening?

OS: Ubuntu 18.04.5 LTS x86_64 
Kernel: 5.11.11-051111-generic
DE: GNOME 3.28.4 
BR: Google Chrome Version 89.0.4389.114 (Official Build) (64-bit)

I recommend uninstalling and then installing the extension again, specially if you'd installed the extension before version 1.1 was released. Also If you have other chromium-based browsers (e.g: brave, chromium, opera, etc.) installed, please let me know if it's not working there either.

If the problem still persists, since I can't reproduce the problem, I can't figure out what's causing it on my own, so please do the following steps:

  1. Remove the extension.
  2. Download the source code from here.
  3. Enable Developer Mode. (How?)
  4. Drag and Drop the extracted folder from the 2nd step in chrome://extensions/.
  5. Hit the shortcut buttons and See if there's any errors like this:
    image
  6. If not, right click on the extension popup logo, choose inspect popup, hit the shortcuts again, and check the console for any errors.
  7. Share the errors here, if there was any.

Please keep me posted on the progress.

@SinaKarimi7
Copy link
Author

SinaKarimi7 commented Apr 11, 2021

@mahdyar I did these steps and pressed Ctrl + Shift + S several times on different web pages.
I just see this in the console. Any idea?
image

@mahdyar
Copy link
Owner

mahdyar commented Apr 11, 2021

@mahdyar I did these steps and pressed Ctrl + Shift + S several times on different web pages.
I just see this in the console. Any idea?
image

Not really, that's because you opened the popup in a chrome:// url which an extension does not have access to.

Can you please install this one and try with CTRL+SHIFT+K?

@SinaKarimi7
Copy link
Author

@mahdyar I did these steps and pressed Ctrl + Shift + S several times on different web pages.
I just see this in the console. Any idea?
image

Not really, that's because you opened the popup in chrome:// url which an extension does not have access to.

Can you please install this one and try with CTRL+SHIFT+K?

I install that and It works with Ctrl + Shift + K :)

@mahdyar
Copy link
Owner

mahdyar commented Apr 11, 2021

@mahdyar I did these steps and pressed Ctrl + Shift + S several times on different web pages.
I just see this in the console. Any idea?
image

Not really, that's because you opened the popup in chrome:// url which an extension does not have access to.
Can you please install this one and try with CTRL+SHIFT+K?

I install that and It works with Ctrl + Shift + K :)

Glad to hear that :)
In addition to your problem, the shortcut won't work in edge either (#16).
I'll make a hotfix tonight, and It'll probably be available on chrome web store in a day or two.

@SinaKarimi7
Copy link
Author

@mahdyar Well done!
IMO, it's better to add a feature for the user to define shortcut in the popup.

@mahdyar mahdyar added the bug Something isn't working label Apr 11, 2021
@mahdyar
Copy link
Owner

mahdyar commented Apr 11, 2021

@mahdyar Well done!
IMO, it's better to add a feature for the user to define shortcut in the popup.

Well, that's a good idea, but as you saw, most of the key bindings are already reserved and do things, so there are not many options for users to define their own.
Also please open a new issue for a feature request and let this be only for Shortcuts don't work in chrome/ubuntu. :)

Update:
You can configure your own shortcut key from v1.3.

@mahdyar mahdyar self-assigned this Apr 11, 2021
@mahdyar mahdyar mentioned this issue Apr 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants