Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCredentials vs getCurrentToken #55

Closed
nabati opened this issue Jan 6, 2016 · 7 comments
Closed

getCredentials vs getCurrentToken #55

nabati opened this issue Jan 6, 2016 · 7 comments

Comments

@nabati
Copy link

nabati commented Jan 6, 2016

Hey,

Thanks for the effort to build this component, I appreciate it!

Just noticed the APIs are different for Android and iOS. Is this by design? FBLoginManager.getCredentials on iOS and FBLoginManager.getCurrentToken for Android. Are there any plans of unifying this API?

@nabati
Copy link
Author

nabati commented Jan 6, 2016

Initially was a bit too hasty with the filing of the issue, but I've updated it now :)

@lwhiteley
Copy link
Contributor

can someone here volunteer to test the mentioned PR
and see if this issue is properly resolved for Android

Please continue the conversation in the Pull Request

#105

[install from my fork directly to test (using github url)]

please see the updated docs on to reference changes for your issue.
If not there please suggest it in the PR

@lwhiteley
Copy link
Contributor

issue resolved by #105

@jpgarcia
Copy link

@lwhiteley The API is still broken between iOS and Android. Shall we consider to reopen this?

// iOS
FBLoginManager.getCredentials((err, data) => {
})

// Android
FBLoginManager.getCredentials(data => {
})

@lwhiteley
Copy link
Contributor

3b14cf5

fixed with the above hash

@jpgarcia
Copy link

Will use this hash till you publish a new version. thanks!

@lwhiteley
Copy link
Contributor

use master, there was a merge error that i resolved after 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants