Include old_owner for transfers in StreamEvent #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothing0012
reviewed
Jun 29, 2023
| @@ -601,6 +605,17 @@ mod stream { | |||
| ) | |||
| .unwrap_or(Address::p2sh(&Script::default(), StreamEvent::get_network()).unwrap()), | |||
| ), | |||
| old_owner: old_satpoint.map(|old| { | |||
| Address::from_script( | |||
| &tx | |||
There was a problem hiding this comment.
this tx was not the old_satpoint tx, it should be the previous one
mi-yu
force-pushed
the
miyu/return-old-owner
branch
from
45bed44
to
0c40e3f
Compare
nothing0012
reviewed
Jun 30, 2023
| @@ -682,6 +684,21 @@ mod stream { | |||
| .unwrap_or_else(|_| panic!("Inscription should exist: {}", self.inscription_id)) | |||
| { | |||
| self.enrich_content(inscription); | |||
| let old_owner: Option<Address> = index | |||
There was a problem hiding this comment.
the &TxOut::default() and the None branch are not consistent of the return I think
nothing0012
reviewed
Jun 30, 2023
| @@ -584,7 +585,7 @@ mod stream { | |||
| block_hash: BlockHash, | |||
| ) -> Self { | |||
| StreamEvent { | |||
| version: "4.0.0".to_owned(), // should match the ord-kafka docker image version | |||
| version: "4.0.2".to_owned(), // should match the ord-kafka docker image version | |||
There was a problem hiding this comment.
oh, should be 4.0.0, the consumer side not smart enough yet
nothing0012
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old_satpoint