Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev server 404 redirect should show 404 page #90

Open
jaeh opened this issue Jan 9, 2020 · 0 comments
Open

dev server 404 redirect should show 404 page #90

jaeh opened this issue Jan 9, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jaeh
Copy link
Member

jaeh commented Jan 9, 2020

there will always be a 404 page.

currently, the dev server router will redirect to WEB_ROOT on 404.

that logic should instead only redirect to WEB_ROOT if the reason for the 404 is that the WEB_ROOT is missing from the start of the request.url,
serving the 404.html page on all other 404s.

@jaeh jaeh self-assigned this Feb 24, 2020
@jaeh jaeh added the enhancement New feature or request label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant