Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make html tags and ModuleViews available in /docsrc/app.mjs #56

Open
jaeh opened this issue Dec 7, 2019 · 0 comments
Open

make html tags and ModuleViews available in /docsrc/app.mjs #56

jaeh opened this issue Dec 7, 2019 · 0 comments
Assignees

Comments

@jaeh
Copy link
Member

jaeh commented Dec 7, 2019

at the moment, in src/cluster/build.mjs,
the app gets prepared before the modules get imported.

the modules then get imported in src/tasks/prepare/globals.mjs.

solution:
refactor the prepare steps to first get all html tags and all MagicModules,
then prepare the app, which in return will include /docsrc/app.mjs,
making modules work in the configuration of @magic-modules/gdpr and other components that have no representation in the code (@magic-modules/light-switch can also self-hoist once that functionality is added, being configured from app.mjs instead of being used in every page.)

@jaeh jaeh self-assigned this Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant