Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Module.Submodule does not get dead_code removed, but Module does. #138

Open
jaeh opened this issue Jun 11, 2020 · 0 comments
Open

BUG: Module.Submodule does not get dead_code removed, but Module does. #138

jaeh opened this issue Jun 11, 2020 · 0 comments

Comments

@jaeh
Copy link
Member

jaeh commented Jun 11, 2020

Fix:
src/lib/babel has a dead_code removal function, which does not detect Module.SubModule after it removed Module.

This is a bug if a @magic-modules is installed and then not used in the pages.

fix: only parse the used and unused tags in dead_code, pass them back, then remove them in one step, together with CHECK_PROPS.

this will also allow removal of actions, effects, subscriptions, libraries and other dead code that the default dead code elimination and treeshaking can not detect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant