Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the welcome message #126

Open
piegamesde opened this issue Apr 30, 2021 · 0 comments
Open

Handle the welcome message #126

piegamesde opened this issue Apr 30, 2021 · 0 comments
Assignees
@piegamesde
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@piegamesde
Copy link
Member

At the moment, we simply pass a pathetic String because nobody bothered implementing it. WormholeWelcome.welcome needs to be a custom type that represents the possible values we may get from the server, including unknown ones.
@piegamesde piegamesde added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 30, 2021
@piegamesde piegamesde self-assigned this Jul 29, 2021
@piegamesde piegamesde mentioned this issue Jul 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piegamesde piegamesde

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support permissions & more magic-wormhole/magic-wormhole.rs
1 participant
@piegamesde