[TASK] Allow urls without .html for CMS.

[lewisvoncken]

Description

Related Issue

Closes #ISSUENUM.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Proposed Labels for Change Type/Package

Checklist:

• I have read the CONTRIBUTING document.
• I have linked an issue to this PR.
• I have indicated the change type and relevant package(s).
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All CI checks are green (linting, build/deploy, etc).
• At least one core contributor has approved this PR.

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

[coveralls]

Coverage remained the same at 76.512% when pulling a0f84e0 on lewisvoncken:patch-1 into bb0f376 on magento-research:develop.

[awilcoxa]

@lewisvoncken can you add additional detail here and include an issue so that the team can review?

[awilcoxa]

placing on hold until detail is added

[lewisvoncken]

@awilcoxa
There is no issue related to this Pull Request but here is a description why this should be merged:

In Magento it is possible to use a suffix in the url which is a configuration option

By default this option is set to .html but only for Catalog Urls

Because of this the CMS page routing won't work correctly because these rewrites don't have .html

To make CMS page routing work correctly it should allow urls without .html Besides that the functionality won't change and the support of a different suffix is also added through this change.

[zetlen]

Thank you! Excellent addition, just needs the outer conditional to be reordered.

[zetlen]

This is the right idea (until we have the store config introspection requested in magento/graphql-ce#535) but it needs to go further down in the stack. Since CMS pages have no suffixes, they now live in the same namespace as some of our hardcoded routes, like checkout. Those hardcoded routes need to resolve first--otherwise, an administrator could accidentally break their store by writing an SEO Friendly URL that conflicts with a builtin PWA route, AND, UPWARD would place the urlResolver call unnecessarily for every single request.