Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get PWA Studio running in Docker container #734

Closed
2 of 11 tasks
sharkySharks opened this issue Jan 9, 2019 · 2 comments
Closed
2 of 11 tasks

Get PWA Studio running in Docker container #734

sharkySharks opened this issue Jan 9, 2019 · 2 comments
Assignees

Comments

@sharkySharks
Copy link
Contributor

This issue is for the following packages:

  • venia-concept
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • all

This issue is a:

  • Bug
  • Feature suggestion
  • Documentation issue
  • Other (Please Specify)

Environment

Question Answer
Magento version
Operating System + version
node.js version (node -v)
npm version (npm -v)

Description

In order to support Windows users and reproduceable environment, getting PWA to run inside of a container with https support would be very helpful.

Expected result:

Run a docker container with PWA that works on any OS that has docker on it.

Possible solutions:

Same as above.

@sharkySharks
Copy link
Contributor Author

sharkySharks commented Jan 23, 2019

Updating this ticket.

Current progress includes:

  • PWA is running in a Docker container over https
  • https was achieved using self-signed certificates and mounting them on the proxy container
  • custom local url support, ie https://pwa-docker.local, using an nginx reverse-proxy to route the requests from the url to the app container
  • PWA service worker confirmed working and the application is running as expected

Items still in progress:

  • Automation script for setting everything up
    • Completed: adding custom host to /etc/hosts file; sourcing environment files; running docker-compose steps).
    • Remaining: automating certificate creation on Mac
  • Mounting volume bridge between host project file system and container project file system without deleting build setup. This would allow the dev the ability to make changes on their computer and have the hot reloading feature of webpack reload their changes inside the container.
  • Documentation

@sharkySharks
Copy link
Contributor Author

Moving Windows support to separate issue. Will complete setup for running on Mac, follow up work for Windows support will be in issue #782

@cherdman cherdman added the hold On hold until another condition is fulfilled. label Jan 24, 2019
@cherdman cherdman removed the hold On hold until another condition is fulfilled. label Feb 4, 2019
@sharkySharks sharkySharks mentioned this issue Feb 6, 2019
8 tasks
@cherdman cherdman added the hold On hold until another condition is fulfilled. label Mar 15, 2019
@sharkySharks sharkySharks removed the hold On hold until another condition is fulfilled. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants