-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc]: Instructions on how to display backend homepage (from CMS) as a homepage for Venia #3033
Comments
Hi @plamenh. Thank you for your report. Please, add a comment to assign the issue:
|
@magento export issue to JIRA project PWA as Story |
✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1490) is successfully created for this issue. |
@plamenh thank you for this request - I have created linked it to our internal backlog and we will get to it when we can :) |
I found the source of the confusion (at least for me): useCmsPage Line 62:
I think this line should go. If it does not, we need this in the docs. |
Are you talking about the static text |
Yeah, I understood that, but I don't get the reasoning behind it. Why not just display the homepage content there regardless of whether it's been changed from default or not? I spent a few hours trying to figure out how to display my homepage when all I had to do is change a text that is stored in the db. Does not make any sense. I mean, why would frontend logic depend on a string of text stored in the database? |
@plamenh Apologies! I forgot to respond. ~17 months ago we made a change to this file in this PR: #1872. There was a comment which seems to have been lost: So it appears that the original intent was literally to prevent the default CMS page text from rendering, but I don't know why we wanted to prevent it. I'm sorry it was confusing - I will see if we can remove that line. |
Ok I spoke to @davemacaulay who reminded me that the reason for this code is so we can render our venia-ui |
It's all good, just that comment is now missing, it would be great if it's back there. Someone might just skim through line 36 w/out investing much thought (as I did). |
Describe the request
Currently, there are no instructions on how to set the homepage to either a concrete CMS page from the backend or the designated (backend) homepage. This is very important for anyone not using EE and Page Builder.
Possible solutions
In order to use a CMS page as a home page you need to:
Please let us know whether this is a new topic or a topic change request:
The text was updated successfully, but these errors were encountered: