Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Implement optimistic updates API. #1776

Closed
3 of 7 tasks
revanth0212 opened this issue Sep 24, 2019 · 3 comments
Closed
3 of 7 tasks

[feature]: Implement optimistic updates API. #1776

revanth0212 opened this issue Sep 24, 2019 · 3 comments
Labels
enhancement New feature or request performance Things related to perf Progress: done

Comments

@revanth0212
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Maybe related to #1673

Describe the solution you'd like
This is something that needs a bit of caution while using. We can use optimistic updates to improve the performance of the app by returning a fake yes from the Service Worker about the update. If for some reason the update fails, a message will be posted back to the client about the failure and necessary actions will be triggered to deal with the failure. This obviously is not applicable for certain actions like placing an order or login but can be very useful when it comes to posting a comment or giving a rating.

It would be straight forward if we implement optimistic updates as part of Venia and Peregrine. But if we need to implement features like #1766 and #1767 we can couple them with this and gain more benefits in the process. We can utilize the postMessage reaction API which will be implemented as part of #1772 for this.

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@revanth0212 revanth0212 added the enhancement New feature or request label Sep 24, 2019
@supernova-at
Copy link
Contributor

We can do this via Apollo too - see #1665 .

@revanth0212 revanth0212 added the performance Things related to perf label Sep 30, 2019
@sirugh
Copy link
Contributor

sirugh commented May 17, 2021

@magento export issue to JIRA project PWA as Story

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/PWA-1765 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Things related to perf Progress: done
Projects
None yet
Development

No branches or pull requests

5 participants