-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Unable to create subfolders inside queries folder #1108
Comments
Not sure if this is a bug because there might be a reason to not structure your query files that I'm not aware of. But if this is in fact a bug i'd like to take ownership |
I don't see any technical reason why we shouldn't do this and I'm cool if @Jordaneisenburger makes this improvement for sure. |
Excellent! Now that #1498 is merged and the |
@zetlen it still works after the merge, well done! |
Describe the bug
Right now it's not possible to create a subfolder inside the
venia-concept/src/queries
the reason you might wanna do this is to better structure your queries.For example you might wanna create a subfolder like
venia-concept/src/queries/category
that contains all queries related to the category.To Reproduce
Steps to reproduce the behavior:
venia-concept/src/queries/category
and keep it empty for now.yarn run build
.yarn run watch:venia
Error: EISDIR: illegal operation on a directory, read
Expected behavior
No error and the watch command just continues to run as usual
Possible solutions
Some globbing should be added to
PWADevServer.js
on line 177 so instead of just returning the direct.graphql
files it should search recursive. This could be done with just plain JS but there seems to be a good package for this see https://github.com/isaacs/node-globPlease complete the following device information:
.env.dist
6.5.0
:v11.9.0
:Please let us know what packages this bug is in regards to:
venia-concept
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
The text was updated successfully, but these errors were encountered: