From 3d1bdf08d1d47e4c18f8f6a036a9c14b548b2c09 Mon Sep 17 00:00:00 2001 From: Kayden Althen Date: Fri, 8 Feb 2019 15:06:02 -0600 Subject: [PATCH] update custom domain to reserved DNS label .localhost --- docker/.env.docker | 2 +- docker/README.md | 2 +- packages/venia-concept/package.json | 2 +- pwa-devdocs/_drafts/docker-setup.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docker/.env.docker b/docker/.env.docker index d3de2f52da..fb97357018 100644 --- a/docker/.env.docker +++ b/docker/.env.docker @@ -9,7 +9,7 @@ MAGENTO_BUILDPACK_PROVIDE_SECURE_HOST=0 PWA_STUDIO_PORTS_DEVELOPMENT=8080 PWA_STUDIO_HOST_DEVELOPMENT=localhost # match PWA_STUDIO_PUBLIC_PATH value with the --host value of the "watch:docker" script in packages/venia-concept/package.json -PWA_STUDIO_PUBLIC_PATH=pwa-docker.local +PWA_STUDIO_PUBLIC_PATH=pwa-docker.localhost ENABLE_SERVICE_WORKER_DEBUGGING=1 UPWARD_JS_UPWARD_PATH=venia-upward.yml UPWARD_JS_BIND_LOCAL=1 diff --git a/docker/README.md b/docker/README.md index f6ad3929bd..038bb79968 100644 --- a/docker/README.md +++ b/docker/README.md @@ -12,7 +12,7 @@ This script will: * run `docker-compose build` to build the container network * run `docker-compose up` to start the container running PWA at the custom domain with https -After `docker/run-docker` is executed from the root of the repository, the default configuration will have the PWA application running at `https://pwa-docker.local`. +After `docker/run-docker` is executed from the root of the repository, the default configuration will have the PWA application running at `https://pwa-docker.localhost`. ### Configure a new custom domain diff --git a/packages/venia-concept/package.json b/packages/venia-concept/package.json index a13300471e..36ca49b618 100644 --- a/packages/venia-concept/package.json +++ b/packages/venia-concept/package.json @@ -27,7 +27,7 @@ "storybook:build": "build-storybook -c .storybook -o storybook-dist", "validate-queries": "node ./validate-queries.js", "watch": "webpack-dev-server --progress --color --env.mode development", - "watch:docker": "webpack-dev-server --progress --color --env.mode development --host pwa-docker.local" + "watch:docker": "webpack-dev-server --progress --color --env.mode development --host pwa-docker.localhost" }, "repository": "github:magento-research/pwa-studio", "author": "Magento Commerce", diff --git a/pwa-devdocs/_drafts/docker-setup.md b/pwa-devdocs/_drafts/docker-setup.md index a3458e8177..7db2812484 100644 --- a/pwa-devdocs/_drafts/docker-setup.md +++ b/pwa-devdocs/_drafts/docker-setup.md @@ -9,7 +9,7 @@ ``` docker/run-docker ``` -4. Once the script completes, a locally running instance of pwa will be available at `https://pwa-docker.local`. +4. Once the script completes, a locally running instance of pwa will be available at `https://pwa-docker.localhost`. The domain is configurable. Two changes are needed to configure a new domain name.