Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back the functionality to use the PHP cookie for GraphQL user #35004

Closed
wants to merge 1 commit into from
Closed

Conversation

jesse-deboer
Copy link

@jesse-deboer jesse-deboer commented Jan 21, 2022

Fixes #28040

Preconditions (*)

  • Sample data
  • Login as Veronica Costello
  • Add any product(s) into a shopping cart

Steps to reproduce (*)

  • Copy PHPSESSID value from a browser window

  • Set PHPSESSID in a header

  • Run the next GraphQL query to retrieve a customer's cart

 {
  cart(cart_id: "kSjlU0dTeaH9CUuaRGFSUTOejwTN9ZLn") {
    id
    items {
      id
      quantity
      product {
        sku
      }
    }
  }
}

Expected result (*)

GraphQl should be authorized by the cookie set in PHP

Actual result (*)

GraphQL call needs a bearer token and won't work

@m2-assistant
Copy link

m2-assistant bot commented Jan 21, 2022

Hi @jesse-deboer. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 17, 2022
@manavluhar
Copy link
Contributor

@jesse-deboer Please Sign CLA

@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2022

Hi @jesse-deboer. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

@magento run Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

Hi @jesse-deboer ,

Thanks for your contribution and collaboration.
I have tried to reproduce the issue in latest 2.4-develop but issue is not reproducible to me. I have followed below steps :

Preconditions:

  • Sample data
  • Login as Veronica Costello
  • Add any product(s) into a shopping cart

Manual testing scenario:

  1. Copy PHPSESSID value from a browser window
  2. Set PHPSESSID in a header
  3. Run the next GraphQL query to retrieve a customer's cart.
 {
  cart(cart_id: "kSjlU0dTeaH9CUuaRGFSUTOejwTN9ZLn") {
    id
    items {
      id
      quantity
      product {
        sku
      }
    }
  }
}

I am able to run above query successfully , I am not getting any error or need of bearer token.
Below is the screenshot for your reference:
image

Kindly provide me more information in order to reproduce the issue.Also,please try in latest 2.4-develop if you are facing any issue let us know.

Thanks

@engcom-Lima
Copy link
Contributor

Hi @jesse-deboer ,

Thanks for your contribution and collaboration.

Kindly provide more information as mentioned in the comment.

Thanks

@engcom-Lima
Copy link
Contributor

Hi @jesse-deboer ,

Thanks for contribution and collaboration.

Closing this PR as there is no update on this from last 14 days. Please feel to reopen it.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GraphQL GraphQL Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQl. Retrieve customer's shopping cart without an authorization token
6 participants