-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding back the functionality to use the PHP cookie for GraphQL user #35004
Conversation
Hi @jesse-deboer. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@jesse-deboer Please Sign CLA |
Hi @jesse-deboer. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @jesse-deboer , Thanks for your contribution and collaboration. Preconditions:
Manual testing scenario:
I am able to run above query successfully , I am not getting any error or need of bearer token. Kindly provide me more information in order to reproduce the issue.Also,please try in latest Thanks |
Hi @jesse-deboer , Thanks for your contribution and collaboration. Kindly provide more information as mentioned in the comment. Thanks |
Hi @jesse-deboer , Thanks for contribution and collaboration. Closing this PR as there is no update on this from last 14 days. Please feel to reopen it. Thanks |
Fixes #28040
Preconditions (*)
Steps to reproduce (*)
Copy PHPSESSID value from a browser window
Set PHPSESSID in a header
Run the next GraphQL query to retrieve a customer's cart
Expected result (*)
GraphQl should be authorized by the cookie set in PHP
Actual result (*)
GraphQL call needs a bearer token and won't work