From 6bb81585f10eb347cd4f35c9a286eab0a2d82d39 Mon Sep 17 00:00:00 2001 From: Anna Pak Date: Fri, 6 Nov 2020 18:37:18 +0200 Subject: [PATCH 1/6] AddOutOfStockProductToCompareListTest refactored --- ...tHoverProductOnCategoryPageActionGroup.xml | 19 +++ .../AddOutOfStockProductToCompareListTest.xml | 120 ++++++++---------- 2 files changed, 72 insertions(+), 67 deletions(-) create mode 100644 app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml new file mode 100644 index 0000000000000..661d40fd4f13a --- /dev/null +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml @@ -0,0 +1,19 @@ + + + + + + + Hover product on the Category page + + + + + + diff --git a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml index 92be79fdfe720..b2fbf2ae3810a 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml @@ -20,7 +20,6 @@ - @@ -30,81 +29,68 @@ + - + - - - + + - - - - - - + + + + + - - + - - + - - + + - - - - - - - - - - - - - - - - ($grabTextFromSuccessMessage) - You added product $$product.name$$ to the comparison list. - - - - - - - - - - - - - - - - - - - - - - - - ($grabTextFromSuccessMessage) - You added product $$product.name$$ to the comparison list. - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + + + + + + + From 1089f15b276cbbe30c2279349a934716148321be Mon Sep 17 00:00:00 2001 From: Anna Pak Date: Thu, 19 Nov 2020 19:08:10 +0200 Subject: [PATCH 2/6] restoring stepKeys --- .../AddOutOfStockProductToCompareListTest.xml | 60 ++++++++++++++----- 1 file changed, 46 insertions(+), 14 deletions(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml index b2fbf2ae3810a..c28c5a040e553 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml @@ -38,15 +38,21 @@ + + - + - + + + + + @@ -54,41 +60,67 @@ - + + + + + + + + + + - + - + + + - + + - + - + + + + - + + + + + - + - + - + + + + + + - + + + - + From 7320189463af8d2a08f6138e524ed4838195d179 Mon Sep 17 00:00:00 2001 From: Anna Pak Date: Mon, 30 Nov 2020 17:15:08 +0200 Subject: [PATCH 3/6] refactored --- .../Mftf/Test/AddOutOfStockProductToCompareListTest.xml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml index c28c5a040e553..d8545c94010dc 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml @@ -87,13 +87,12 @@ - + - - - - + + + From 8ba2695458f6c686a1caafb5cd629b0f67a85f10 Mon Sep 17 00:00:00 2001 From: Anna Pak Date: Tue, 1 Dec 2020 08:57:26 +0200 Subject: [PATCH 4/6] fixed indentation --- .../StorefrontHoverProductOnCategoryPageActionGroup.xml | 4 ++-- .../Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml index 661d40fd4f13a..10d85a91a02c6 100644 --- a/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml +++ b/app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml @@ -10,10 +10,10 @@ xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> - Hover product on the Category page + Hover product on the Category page - + diff --git a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml index d8545c94010dc..8911e5d04fe4a 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml @@ -31,7 +31,7 @@ - + From d001c99173bbf407587b4ece8f8d51fec6e4f56c Mon Sep 17 00:00:00 2001 From: Anna Pak Date: Tue, 1 Dec 2020 09:00:50 +0200 Subject: [PATCH 5/6] fixed indentation --- .../Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml index 8911e5d04fe4a..7f4228a21f3d5 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml @@ -120,7 +120,7 @@ - + From 125b01a296c165afd53d8f13ceb35b0e13716702 Mon Sep 17 00:00:00 2001 From: Pavel Bystritsky Date: Fri, 18 Dec 2020 11:52:56 +0200 Subject: [PATCH 6/6] magento/magento2#31131: [MFTF] Refactoring of AddOutOfStockProductToCompareListTest. --- .../AddOutOfStockProductToCompareListTest.xml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml index 7f4228a21f3d5..995fa4c7e5977 100644 --- a/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml +++ b/app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml @@ -20,6 +20,7 @@ + @@ -35,8 +36,9 @@ - - + + + @@ -48,10 +50,10 @@ - + - + @@ -72,13 +74,13 @@ - + - + @@ -112,13 +114,13 @@ - + - +