Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#: Add additional test coverage to “updateCustomer” mutation #28304

Merged
merged 1 commit into from
Jun 5, 2020
Merged

magento/magento2#: Add additional test coverage to “updateCustomer” mutation #28304

merged 1 commit into from
Jun 5, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented May 20, 2020 •
edited by ghost
Loading

Description (*)

PR adds a test coverage for the next cases of updateCustomer mutation:

  • Invalid date of birth
  • Invalid email address
  • Empty customer last name

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] magento/magento2#: Add additional test coverage to “updateCustomer” mutation #28394: magento/magento2#: Add additional test coverage to “updateCustomer” mutation

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 20, 2020
@rogyar rogyar self-assigned this May 20, 2020
@atwixfirster
Copy link
Contributor Author

@magento run all tests

@atwixfirster atwixfirster force-pushed the graphql-updateCustomer branch from 4075f51 to 62f5c32 Compare May 22, 2020 15:50
@atwixfirster
Copy link
Contributor Author

@magento run all tests

@atwixfirster
Copy link
Contributor Author

@rogyar , could you please review this one? Failed static tests are not tie to a proposed changes.

Thank you!

@atwixfirster atwixfirster force-pushed the graphql-updateCustomer branch from e387b33 to 62f5c32 Compare May 23, 2020 14:02
@rogyar
Copy link
Contributor

rogyar commented May 26, 2020

@magento run all tests

@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise labels May 26, 2020
rogyar
rogyar approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not related to the current changes

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7593 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 27, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this May 27, 2020
@engcom-Charlie
Copy link
Contributor

Failed tests not related to changes from this PR.

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 27, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 27, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 27, 2020
@slavvka
Copy link
Member

slavvka commented May 27, 2020

@magento create issue

@ghost ghost mentioned this pull request May 27, 2020
Closed
4 tasks
@sdzhepa sdzhepa removed the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 1, 2020
@engcom-Charlie
Copy link
Contributor

Failed tests not related to changes from this PR.

magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2020
@slavvka
ENGCOM-7593: magento/magento2#: Add additional test coverage to “upda…
e0e7a91 
…teCustomer” mutation #28304
@magento-engcom-team magento-engcom-team merged commit efc4244 into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] magento/magento2#: Add additional test coverage to “updateCustomer” mutation
7 participants
@atwixfirster @rogyar @magento-engcom-team @engcom-Alfa @engcom-Charlie @slavvka @sdzhepa