Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo issue and added missing header in customer sales order grid #22643

Conversation

vishal-7037
Copy link
Contributor

Description (*)

Fixed Typo issue as well as added header title for Last Action Column

Fixed Issues (if relevant)

  1. Typo Issue and Missing header title at Customer Sales order grid  #22641: Typo Issue and Missing header title at Customer Sales order grid

Manual testing scenarios (*)

  1. Login to Magento admin
  2. Open Customer > All Customers > Edit any customer
  3. Check header title of Order column and header title of last column.

Before Fixed:
magento_customer_order_grid

After Fixed:
magento_customer_order_grid_fixed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @vishal-7037. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@vishal-7037
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @vishal-7037. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vishal-7037, here is your new Magento instance.
Admin access: https://pr-22643.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@vishal-7037
Copy link
Contributor Author

I've tested at Vanilla Magento 2.3 Instance and working fine.

vanila_customer_sales_grid

Thanks.

@rogyar rogyar self-assigned this May 5, 2019
@rogyar
Copy link
Contributor

rogyar commented May 5, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-22643.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar mentioned this pull request May 5, 2019
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5059 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented May 7, 2019

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @vishal-7037, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants