-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update credit-card-number-validator.js #22493
Update credit-card-number-validator.js #22493
Conversation
Hi @justin-at-demac. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
@justin-at-bounteous thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
✔️ QA Passed |
Hello @justin-at-bounteous, this PR commit looks like has email which not from GitHub user. Could you please check this and sign CLA, to process your pull request? |
Hi @nmalevanec, the user is myself. I made the commit through the GitHub interface. And afterward updated my username and email. That may have caused the issue. |
Hi @justin-at-bounteous , unfortunately, we can't accept the pull request with a commit that not associated with GitHub user. Please, make the new commit with your current email and force push the changes. Thank you! |
- Remove: erroneous leading alternation, preventing space characters from being replaced - Add: replace each contiguous string of space characters, for good measure
Hi @sidolov , how about now? The commit has been revised. The author is now this proper github account |
@justin-at-bounteous perfect! thank you! |
Hi @justin-at-bounteous, thank you for your contribution! |
Changes:
Issues Addressed: