Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credit-card-number-validator.js #22493

Merged
merged 1 commit into from
May 8, 2019
Merged

Update credit-card-number-validator.js #22493

merged 1 commit into from
May 8, 2019

Conversation

justin-at-bounteous
Copy link
Contributor

Changes:

  • Remove: erroneous leading alternation, preventing space characters from being replaced
  • Add: replace each contiguous string of space characters, for good measure

Issues Addressed:

  • with the leading alternation present, whitespace is not removed and the credit card number always fails validation

@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2019

Hi @justin-at-demac. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 25, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4826 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@justin-at-bounteous thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii
Copy link

✔️ QA Passed

@nmalevanec
Copy link
Contributor

Hello @justin-at-bounteous, this PR commit looks like has email which not from GitHub user. Could you please check this and sign CLA, to process your pull request?

@justin-at-bounteous
Copy link
Contributor Author

Hi @nmalevanec, the user is myself. I made the commit through the GitHub interface. And afterward updated my username and email. That may have caused the issue.

@sidolov
Copy link
Contributor

sidolov commented Apr 30, 2019

Hi @justin-at-bounteous , unfortunately, we can't accept the pull request with a commit that not associated with GitHub user. Please, make the new commit with your current email and force push the changes. Thank you!

- Remove: erroneous leading alternation, preventing space characters from being replaced
- Add: replace each contiguous string of space characters, for good measure
@justin-at-bounteous
Copy link
Contributor Author

Hi @sidolov , how about now? The commit has been revised. The author is now this proper github account

@sidolov
Copy link
Contributor

sidolov commented May 1, 2019

@justin-at-bounteous perfect! thank you!

@ghost ghost added the Progress: accept label May 1, 2019
@magento-engcom-team magento-engcom-team merged commit a69e9e9 into magento:2.3-develop May 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2019

Hi @justin-at-bounteous, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request May 8, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants