-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow import to skip errors #17332
Allow import to skip errors #17332
Conversation
Hi @superdav42. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
553d359
to
ea20de5
Compare
@dmanners could you review this PR? |
Thanks for the note @ihor-sviziev I will take a look at this |
Hi @superdav42 thanks for this PR, would you be able to look into the failing Unit and integration tests for me? Once you have these sorted then I can process this PR. |
@superdav42 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @superdav42 , I am closing this PR now due to inactivity. |
Which are failing? |
@superdav42 just look at build on Travis: |
Description
This appears to be a bug that has been in the codebase 3+ years? Maybe it never worked. The "skip error entries" essentially does nothing when importing products or customers. With this PR they can be skipped as expected.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist