Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import to skip errors #17332

Conversation

superdav42
Copy link

Description

This appears to be a bug that has been in the codebase 3+ years? Maybe it never worked. The "skip error entries" essentially does nothing when importing products or customers. With this PR they can be skipped as expected.

Fixed Issues (if relevant)

  1. Magento 2.2.2-dev - CSV Import, skip errors not working magento-engcom/import-export-improvements#75: Magento 2.2.2-dev - CSV Import, skip errors not working
  2. Magento 2.2.2-dev - CSV Import, skip errors not working #12808: Magento 2.2.2-dev - CSV Import, skip errors not working

Manual testing scenarios

  1. Import csv with one or more validation errors
  2. Interface will indicate an error was found but allow user to continue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @superdav42. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@superdav42 superdav42 force-pushed the Fix-Import-On-Error-MAGETWO-85966 branch from 553d359 to ea20de5 Compare August 2, 2018 21:50
@ihor-sviziev
Copy link
Contributor

@dmanners could you review this PR?

@ihor-sviziev ihor-sviziev requested a review from dmanners August 8, 2018 19:50
@dmanners
Copy link
Contributor

Thanks for the note @ihor-sviziev I will take a look at this

@dmanners
Copy link
Contributor

Hi @superdav42 thanks for this PR, would you be able to look into the failing Unit and integration tests for me? Once you have these sorted then I can process this PR.

@dmanners dmanners self-assigned this Aug 10, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 10, 2018
@magento-engcom-team
Copy link
Contributor

@superdav42 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov
Copy link
Contributor

sidolov commented Aug 25, 2018

Hi @superdav42 , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 25, 2018
@superdav42
Copy link
Author

Which are failing?

@ihor-sviziev
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants