-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to create Text Swatch 0 (Zero) #9619
Comments
@oroskodias Unfortunately, I could not reproduce the issue as you described it. Can you please let me know is this problem is relevant for latest Magento 2 release version? |
@smoskaluk I see same code in 2.1.7. Issue is still there |
See also #10266 |
This was fixed in #7701 but not backported to 2.1.x yet. |
Fix for develop: MAGETWO-66160 |
Fix for 2.1-develop: MAGETWO-70838 |
Internal ticket to track issue progress: MAGETWO-70838 |
@oroskodias, thank you for your report. |
Preconditions
Steps to reproduce
Try to create product attribute text swatch with value "0" (zero)
Expected result
New value for attribute
Actual result
Admin is a required field in the each row
To see recorded behaviour: http://recordit.co/bUwOLQQ3n2
After saving:
Quick Fix
module-swatches/Model/Plugin/EavAttribute.php
Method
isOptionsValid()
Instead of this:
if (empty($option[0])) { return false; }
Type this:
if($option[0] != '0'){ if (empty($option[0])) { return false; } }
The text was updated successfully, but these errors were encountered: