Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1 catalog filter displaying below grid #5408

Closed
maderlock opened this issue Jul 1, 2016 · 7 comments
Closed

2.1 catalog filter displaying below grid #5408

maderlock opened this issue Jul 1, 2016 · 7 comments
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@maderlock
Copy link

Steps to reproduce

  1. 2.0.7 upgraded to 2.1.0 running on PHP 7.0.7
  2. Plenty of products added
  3. Visit admin product catalog page

Expected result

  1. In 2.0.7 the filters were above the grid

Actual result

  1. They are now displaying below the grid. Screenshot:
    screenshot 2016-07-01 16 43 11

If there is a full page of products in the grid then they cannot be seen at all. The fixed tool-bar section still is shown when scrolling, but clicking of the filter icon does not make it appear.

I note that the knockoutjs template has the filter after the grid, so something should be rearranging it. There are no javascript errors, so I do not know what might be causing this.

I don't know if the above instructions will be sufficient to reproduce, but I don't know what else is relevant.

@maderlock
Copy link
Author

Having added a column to the order grid as well I'm getting the same issue, so this seems to be a function of custom columns. Is there any known cure?

@reijervano
Copy link

Does anyone knows a workaround?

@kanduvisla
Copy link
Contributor

I'm running in this problem too. I try to add a custom column to the order grid with my custom view/adminhtml/ui_component/sales_order_grid.xml:

<?xml version="1.0" encoding="UTF-8"?>
<listing xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
    <columns name="sales_order_columns">
        <column name="order_reference">
            <argument name="data" xsi:type="array">
                <item name="config" xsi:type="array">
                    <item name="dataType" xsi:type="string">text</item>
                    <item name="visible" xsi:type="boolean">true</item>
                    <item name="label" xsi:type="string" translate="true">Order Reference</item>
                </item>
            </argument>
        </column>
    </columns>
</listing>

Doing this moves the filters to the bottom. Any thoughts on this?

@kanduvisla
Copy link
Contributor

Small update: it probably has something to with the order how UI components are rendered. If you add an empty <listingToolbar name="listing_top"/> above your <columns>-tag, it works. My main guess is because this way the element will already be created in the javascript-array that renders the HTML.

It might also have something to do with a ticket I filed a while back which shows an issue that happens with how various XML files get merged into one: #8647

@magento-engcom-team magento-engcom-team added 2.1.x bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@maderlock, thank you for your report.
The issue is already fixed in develop branch, 2.2.0, 2.1.9

@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 18, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 18, 2017
@meezin
Copy link

meezin commented Nov 8, 2017

@magento-engcom-team Hi there! It doesn't fix in 2.1.9

@fauzie
Copy link

fauzie commented Aug 23, 2018

@magento-engcom-team It doesn't fix also in 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests

8 participants