Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luma theme meta viewport tag contains maximum-scale=1.0, user-scalable=no #5403

Closed
svossen opened this issue Jul 1, 2016 · 2 comments
Closed

Comments

@svossen
Copy link

svossen commented Jul 1, 2016

The Luma theme viewport meta tag contains maximum-scale=1.0, user-scalable=no. This is a really bad practise and is really harmful for the accessibility of the interface! Developers should not decide how a user should interact with the interface. This should be up to the user.

Fortunately the blank theme contains the correct meta viewport tag. But some shops will probably use
Luma as main theme or as fallback so it's important that those values are removed from the Luma theme as well.

Steps to reproduce

Always, meta tag is added to the header

Expected result

<meta name="viewport" content="width=device-width, initial-scale=1">

Actual result

<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no">

@hostep
Copy link
Contributor

hostep commented Jul 1, 2016

There used to be a discussion about this a while ago, see: #1733

@svossen
Copy link
Author

svossen commented Jul 1, 2016

Missed that one. Thank you.

@svossen svossen closed this as completed Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants