Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouped Product Quantity Validation Displays Errors for All Inputs When One Input Is Invalid #39347

Open
5 tasks
allforcode opened this issue Nov 8, 2024 · 7 comments · May be fixed by #39377
Open
5 tasks

Grouped Product Quantity Validation Displays Errors for All Inputs When One Input Is Invalid #39347

allforcode opened this issue Nov 8, 2024 · 7 comments · May be fixed by #39377
Assignees
@Mohamed-Asar
Labels
Area: Product Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@allforcode
Copy link

Preconditions and environment

  • Magento Versions
    I tested in Magento 2.4.7 and Magento 2.4.7-p2

  • Description
    On the grouped product page, entering a single invalid quantity (e.g., a negative value) causes error messages to appear for all quantity input fields, even if the other inputs have valid values. This behavior creates confusion for users who have correctly entered quantities.

Steps to reproduce

  1. Navigate to a grouped product page.
  2. Enter a negative value (e.g., -10) in one of the quantity input fields.
  3. Enter valid values (e.g., 6 or 9) in the other quantity input fields.
  4. Observe the error messages displayed.

Cursor_and_Set_of_Sprite_Yoga_Straps

Expected result

Only the input field with an invalid quantity should display an error message.

Actual result

All input fields display an error message, even if their values are valid.

Additional information

In Magento 2.4.5, the form validation is handled by view/frontend/web/product/view/validation.js, whereas in Magento 2.4.7, it is managed by lib/web/mage/validation.js.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 8, 2024

Hi @allforcode. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 8, 2024
@engcom-Bravo engcom-Bravo self-assigned this Nov 8, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 8, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. label Nov 8, 2024
@engcom-Bravo
Copy link
Contributor

Hi @allforcode,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Navigate to a grouped product page.
  • Enter a negative value (e.g., -10) in one of the quantity input fields.
  • Enter valid values (e.g., 6 or 9) in the other quantity input fields.
  • Observe the error messages displayed.

Group-11-08-2024_09_48_AM

All input fields displays error message, even if their values are valid.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Product labels Nov 8, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13325 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 8, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@Mohamed-Asar
Copy link
Contributor

@magento I'm working on this

@Mohamed-Asar Mohamed-Asar linked a pull request Nov 17, 2024 that will close this issue
Open
5 tasks
@engcom-Bravo engcom-Bravo mentioned this issue Nov 19, 2024
Closed
5 tasks
@phes71
Copy link

phes71 commented Nov 19, 2024

this will fix it 95fd74f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mohamed-Asar Mohamed-Asar

Labels
Area: Product Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AC-13325 Issue#39347 grouped product qty validation issue fix Mohamed-Asar/magento2
5 participants
@phes71 @allforcode @engcom-Bravo @Mohamed-Asar @github-jira-sync-bot