Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade to magento 2.4.7 p2 can't see newly uploaded files media gallery #39275

Open
1 of 5 tasks
james4563 opened this issue Oct 17, 2024 · 8 comments
Open
1 of 5 tasks
Labels
Area: Content Component: MediaGallery Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@james4563
Copy link

Preconditions and environment

  • Magento version 2.4.7 p2
  • Upgraded from 2.4.6 p6

Steps to reproduce

  1. Goto Media gallery
  2. Click category folder
  3. Click upload image and pick an image to upload
  4. Image is upload okay
  5. Search for image, it's not found

Expected result

Expect the search to show the new file that was uploaded

Actual result

No error messages, but the image that was uploaded isn't present

Additional information

I have noticed that the images do appear it seems after manual sync with bin/magento media-gallery:sync

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Oct 17, 2024

Hi @james4563. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@james4563
Copy link
Author

@magento give me 2.4-develop instance

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. label Oct 17, 2024
@engcom-Delta engcom-Delta self-assigned this Oct 18, 2024
Copy link

m2-assistant bot commented Oct 18, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@james4563
Copy link
Author

james4563 commented Oct 18, 2024

@engcom-Delta FYI, I haven't been able to try this on a clean build because i didn't have access to one. I have however found out the issue.

There is a check in SaveImageInformation.php isApplicable which validates against imageExentions that are set as argument via di type. This array is only "svg, webp" where as it used to be the following which would allow other extensions. Now if you don't upload a svg or webp it wont show in media gallery because isApplicable will return false.

<type name="Magento\MediaGalleryIntegration\Plugin\SaveImageInformation"> <arguments> <argument name="imageExtensions" xsi:type="array"> <item name="jpg" xsi:type="string">jpg</item> <item name="jpeg" xsi:type="string">jpeg</item> <item name="gif" xsi:type="string">gif</item> <item name="png" xsi:type="string">png</item> </argument> </arguments> </type>

I'm quite new to magento, but it seems like moving this arguments means they are not being applied in the same way.

The arguments have been moved from module-media-gallery-integration/etc/adminhtml/di.xml to module-media-gallery-integration/etc/di.xml

@james4563
Copy link
Author

Looks like this is also related to plugins that would add new extensions to the imageExtension arguments.
SVG & WEBP are added by a plugin, but because imageExtension argument has been moved to root scope, rather than adminhtml the plugins will override imageExtensions instead of adding now.

I guess the question is should the imageExtensions argument have been moved to the /etc/di.xml, rather than adminhtml scope.

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Oct 18, 2024

Hi @james4563 ,

Thanks for your reporting and collaboration.
We have verified the issue in latest 2.4.7-p2 and 2.4.7-p3 instance and the issue is reproducible.
Kindly refer the screenshots.

Steps to reproduce

  1. Goto Media gallery
  2. Click category folder
  3. Click upload image and pick an image to upload
validation 4. Image is upload okay 5. Search for image, it's not found

Thanks.

@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: MediaGallery Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Content and removed Issue: ready for confirmation labels Oct 18, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13262 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Oct 18, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Delta engcom-Delta added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: MediaGallery Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

4 participants