Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Fix import iframe visibility #39267

Open
5 tasks
m2-assistant bot opened this issue Oct 16, 2024 · 4 comments · May be fixed by #39265
Open
5 tasks

[Issue] Fix import iframe visibility #39267

m2-assistant bot opened this issue Oct 16, 2024 · 4 comments · May be fixed by #39265
Assignees
Labels
Area: Import / export Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 16, 2024

This issue is automatically created based on existing pull request: #39265: Fix import iframe visibility


Description

An iframe is displayed at the bottom of the import page during validation and subsequent data import

The display attribute with the value none is added to the iframe, previously it was style="display:none", but during refactoring this was incorrectly changed.

Related Commit

1edf224#diff-3160ffecaaf7ab21ba68a3b535d34ab5719602af66952aabe8a821cfac42da9aR172

Manual testing scenarios (*)

  1. Go to the import page in the admin panel
  2. Select any type of entity
  3. Upload the file for import
  4. Click "Check data"
  5. Click "Import"
  6. Scroll window to the bottom

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Oct 16, 2024 that will close this issue
6 tasks
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Oct 16, 2024
@engcom-Bravo engcom-Bravo self-assigned this Oct 16, 2024
Copy link
Author

m2-assistant bot commented Oct 16, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Oct 16, 2024
@engcom-Bravo
Copy link
Contributor

Hi @DmitryFurs,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Manual testing scenarios

  • Go to the import page in the admin panel
  • Select any type of entity
  • Upload the file for import
  • Click "Check data"
  • Click "Import"
  • Scroll window to the bottom
Screenshot 2024-10-17 at 09 51 49

The display attribute with the value none is added to the iframe.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Import / export and removed Issue: ready for confirmation labels Oct 17, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13250 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Oct 17, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Import / export Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants