Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luma theme - Input Box and Radio Button shadow is not proper #20859

Closed
saphaljha opened this issue Jan 31, 2019 · 23 comments
Closed

Luma theme - Input Box and Radio Button shadow is not proper #20859

saphaljha opened this issue Jan 31, 2019 · 23 comments
Assignees
Labels
Area: Design/Frontend Area: Frontend Component: Ui Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@saphaljha
Copy link
Contributor

Preconditions (*)

1.Magento 2.3 and Magento 2.2.X

Steps to reproduce (*)

  1. Magento luma theme frontend in all the form
  2. You can find checkbox, Radio input box shaddow
    Reproduce pages : create account page, cart page and chekout page

Expected result (*)

  1. Screenshot URL: http://prntscr.com/menfs1

Actual result (*)

  1. Screenshot URL: http://prntscr.com/mennmt
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

Hi @saphaljha. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@saphaljha do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 31, 2019
@mage2pratik mage2pratik self-assigned this Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

Hi @mage2pratik. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@abrarpathan19 abrarpathan19 self-assigned this Jan 31, 2019
@mage2pratik mage2pratik added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

Hi @abrarpathan19. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@mage2pratik
Copy link
Contributor

reproduce
reproduce1

@mage2pratik mage2pratik reopened this Jan 31, 2019
@mage2pratik mage2pratik added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 31, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

@mage2pratik Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@mage2pratik mage2pratik added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ui labels Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @mage2pratik
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@mage2pratik mage2pratik added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @mage2pratik
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@nainesh2jcommerce nainesh2jcommerce added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento magento deleted a comment from magento-engcom-team Jan 31, 2019
@mage2pratik
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@mage2pratik mage2pratik added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @mage2pratik
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@mage2pratik
Copy link
Contributor

@magento-engcom-team : As I've confirmed the issue but not able to add Issue: Confirmed label.

@mage2pratik mage2pratik self-assigned this Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 31, 2019

Hi @mage2pratik. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@mage2pratik mage2pratik added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @mage2pratik
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@amol2jcommerce amol2jcommerce added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @amol2jcommerce
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 31, 2019
@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 1, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98019, MAGETWO-98020 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@shikhamis11 shikhamis11 added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your report.
The issue has been fixed in #20861 by @abrarpathan19 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@dmytro-ch
Copy link
Contributor

Hi guys,
it looks like the latest changes violate accessibility standards by complicating the navigation through a keyboard interface.

https://www.w3.org/TR/WCAG20/#keyboard-operation

The purpose of this shadow is to highlight the focus on the element. And as for me, we have nothing to fix here. :)
After the latest fixes, it's hard to guess which element is under focus.

Shouldn't we revert these changes?

@sidolov @VladimirZaets

@abrarpathan19
Copy link
Contributor

@dmytro-ch As per your suggestion, we can do manage shadow design: http://prntscr.com/mjws42

@eduard13
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your Magento instance.
Admin access: https://i-20859-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your report.
The issue has been fixed in #21851 by @eduard13 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Component: Ui Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

9 participants