Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On account my recent reviews alignment issue #20800

Closed
priti2jcommerce opened this issue Jan 30, 2019 · 12 comments
Closed

On account my recent reviews alignment issue #20800

priti2jcommerce opened this issue Jan 30, 2019 · 12 comments
Assignees
Labels
Area: Design/Frontend Component: Review Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Jan 30, 2019

Preconditions (*)

  1. 2.3.0

Steps to reproduce (*)

  1. add reviews with logged in customer
  2. on my account dashboard
  3. reviews alignment not proper (vertically)

Expected result (*)

2019-01-30_16-50_my account 2

Actual result (*)

2019-01-30_16-50_my account

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@priti2jcommerce do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@nainesh2jcommerce nainesh2jcommerce self-assigned this Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@nainesh2jcommerce nainesh2jcommerce added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Area: Design/Frontend Component: Review labels Jan 30, 2019
@nainesh2jcommerce
Copy link
Contributor

issue reproduce on previously provided instance
image

@nainesh2jcommerce nainesh2jcommerce added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

@nainesh2jcommerce Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97985 were created

Issue Available: @nainesh2jcommerce, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 30, 2019
@nainesh2jcommerce nainesh2jcommerce self-assigned this Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@nainesh2jcommerce nainesh2jcommerce added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 30, 2019
@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

@priti2jcommerce @nainesh2jcommerce could you provide more information regarding this issue, please? The difference between these two screenshots is in a slightly increased gap between the summary and the rating starts.
The question is why the current space between the two mentioned elements is incorrect? I believe the good point here would be mentioning relations (i.e. the gap here should be increased because other elements on the page have the same gap).
Thank you

@priti2jcommerce
Copy link
Contributor Author

Hi @rogyar

there is vertical alignment issue
image

@nainesh2jcommerce nainesh2jcommerce removed their assignment Jan 30, 2019
@rogyar
Copy link
Contributor

rogyar commented Jan 31, 2019

Hi @priti2jcommerce. Thank you for the clarification. Could you provide more details (via text) why do you consider this alignment as an issue? Do the other elements on this page have different alignment rules? Thank you.

@priti2jcommerce
Copy link
Contributor Author

priti2jcommerce commented Feb 1, 2019

Hi @rogyar ,

I have checked and found that there is text going to top and rating on bottom, that is not looking proper at the browser that's why consider as a bug and other text look vertically centered.
Please review
Thanks!

@rogyar
Copy link
Contributor

rogyar commented Feb 5, 2019

Thank you for the details

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your report.
The issue has been fixed in #20801 by @priti2jcommerce in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your report.
The issue has been fixed in #21172 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Component: Review Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants