Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to proceed massaction "Update attributes" with required multiple select attribute #11329

Closed
tcurilla opened this issue Oct 10, 2017 · 4 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@tcurilla
Copy link

Preconditions

  1. Magento ver. 2.2.0
  2. PHP 7.0.24

Steps to reproduce

  1. clean install
  2. create product attribute Multiple Select with id "test_multiselect" and set required values to true
  3. fill some options values
  4. create product with previously created multiple select attribute
  5. save product
  6. In Adminhtml -> Catalog -> Products grid select product and do massaction "Update attributes"
  7. click on SAVE

Expected result

  1. Saving must be processed without error

Actual result

  1. Error "The value of attribute "test_multiselect" must be set" is shown
    image

Possible solution

In class method \Magento\Framework\Data\Form\Element\Multiselect::getElementHtml()
add "id" attribute to hidden element

if ($this->getCanBeEmpty()) {
    $html .= '<input type="hidden" name="' . parent::getName() . '" value="" />';
}

change to

if ($this->getCanBeEmpty()) {
    $html .= '<input type="hidden" id="' . $this->getHtmlId() . '_hidden" name="' . parent::getName() . '" value="" />';
}

see Magento_Catalog view/adminhtml/web/catalog/product.js disableFieldEditMode/enableFieldEditMode methods

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Oct 10, 2017
@magento-engcom-team
Copy link
Contributor

@tcurilla, thank you for your report.
We've created internal ticket(s) MAGETWO-81398 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 10, 2017
@magento-engcom-team
Copy link
Contributor

Hi @tcurilla the issue has been fixed in 2.2-develop branch and will be available with release 2.2.1 soon.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 12, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81467

@okorshenko
Copy link
Contributor

Hi @tcurilla. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1323 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants