Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipping method radios have duplicate IDs on cart page #10795

Closed
wsajosh opened this issue Sep 6, 2017 · 5 comments
Closed

Shipping method radios have duplicate IDs on cart page #10795

wsajosh opened this issue Sep 6, 2017 · 5 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development up for grabs

Comments

@wsajosh
Copy link
Contributor

wsajosh commented Sep 6, 2017 •
edited by magento-engcom-team
Loading

Preconditions

  1. Magento CE v2.1 installed

Steps to reproduce

  1. Can't reproduce using core Magento shipping carriers. Need two shipping carriers with different carrier codes but same method codes.

E.g: UPS with GND and 1DA and UPS_1 with GND and 1DA

Expected result

  1. Should be able to select Ground from either carrier

Actual result

  1. Clicking on the first Ground

Issue would appear to lie in: vendor/magento/module-checkout/view/frontend/web/template/cart/shipping-rates.html

The id of the radio is being set to 's_method_' + method_code whereas which would for the above scenario would result in two radio elements both with the ID of "s_method_GND"

However, in the checkout/shipping.html file there's a check to see if there's other rates, and if there is the ID is set to 's_method_' + method.carrier_code + '_' + method.method_code which works correctly.

The fix would be to implement the same logic on the cart estimator
@orlangur
Copy link
Contributor

orlangur commented Sep 6, 2017

Implementation approach looks good to me, are you interested in preparing a pull request maybe?

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 7, 2017
This was referenced Oct 12, 2017
Merged
Merged
Merged
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81830

@magento-team magento-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 16, 2017
@okorshenko
Copy link
Contributor

Hi @wsajosh the issue has been fixed in 2.2-develop branch and will be available in 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 17, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81975

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@orlangur @magento-team @wsajosh @okorshenko @magento-engcom-team