Skip to content

Commit

Permalink
Resolved issue #9243:
Browse files Browse the repository at this point in the history
- Removed Magento\Framework\Locale\CurrencyInterface from setService method and changed it to \Zend_Currency_CurrencyInterface which must be provider to this function.
- Changed return type to \Zend_Currency_CurrencyInterface, the given instance of the service is returned by the setService function
- Removed \Zend_Service from getService method and changed it to \Zend_Currency_CurrencyInterface
- Added @deprecated tags to both methods and added @see annotation to the methods. Referenced corresponding interface \Magento\Directory\Model\Currency\Import\ImportInterface
  • Loading branch information
dverkade committed Jan 2, 2018
1 parent bce891d commit 68389d6
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions lib/internal/Magento/Framework/CurrencyInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -239,15 +239,19 @@ public function isLess($value, $currency = null);
/**
* Returns the set service class
*
* @return \Zend_Service
* @return \Zend_Currency_CurrencyInterface
* @deprecated
* @see \Magento\Directory\Model\Currency\Import\ImportInterface
*/
public function getService();

/**
* Sets a new exchange service
*
* @param string|\Magento\Framework\Locale\CurrencyInterface $service Service class
* @return \Magento\Framework\CurrencyInterface
* @param string|\Zend_Currency_CurrencyInterface $service Service class
* @return \Zend_Currency_CurrencyInterface
* @deprecated
* @see \Magento\Directory\Model\Currency\Import\ImportInterface
*/
public function setService($service);
}

0 comments on commit 68389d6

Please sign in to comment.