Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Avoid using self-closing tag" rule is false positive with inline svg #402

Open
plumrocket opened this issue Jun 13, 2022 · 2 comments
Open
Labels

Comments

@plumrocket
Copy link

plumrocket commented Jun 13, 2022

As SVG content must be in XML format it must be excluded from HTML validation.

Preconditions

  1. Installed Magento Coding Standard V19 or above

Steps to reproduce

  1. Add inline svg to test.html file
  2. Run vendor/bin/phpcs --severity=10 --standard=Magento2 --ignore-annotations test.html

Expected result

  1. No errors appear

Actual result

  1. Errors are appear
    Avoid using self-closing tag with non-void html element - <rect x="12" width="439" height="344" fill="url(#pattern0)"/>
@plumrocket plumrocket added the bug Something isn't working label Jun 13, 2022
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2022

Hi @plumrocket. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@davidwindell
Copy link

This is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants