Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests available in Magento2 repo when creating a pr here. #3377

Open
leonhelmus opened this issue Mar 8, 2023 · 1 comment
Open

Comments

@leonhelmus
Copy link

leonhelmus commented Mar 8, 2023

Summary (*)

At the moment I'm adding constructor properties promotions throughout all of the msi modules.

Since as of 2.4.6 php 7 has been dropped. To be sure I don't break anything this repo should get static tests as well as well as all the other tests available in Magento2 repo to garantue quality when creating a PR.

Examples (*)

Proposed solution

@m2-assistant
Copy link

m2-assistant bot commented Mar 8, 2023

Hi @leonhelmus. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@leonhelmus leonhelmus changed the title Missing tests available in Magento2 repo. Missing tests available in Magento2 repo when creating a pr here. Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant