This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document catalog configuration added to storeConfig query #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These elements were added in magento/graphql-ce#650 Fixes magento/graphql-ce#768
magento-engcom-team
added
Partner: Something Digital
partners-contribution
PR created by Magento partner
labels
Jul 10, 2019
An admin must run tests on this PR before it can be merged. |
rogyar
added
Major Update
Significant original updates to existing content
2.3.x
Magento 2.3 related changes
labels
Jul 10, 2019
rogyar
approved these changes
Jul 10, 2019
keharper
suggested changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of applying real attribute descriptions. I hate that devdocs and the source differ. Someday I'll create a code PR to sync them up.
keharper
approved these changes
Jul 24, 2019
running tests |
Hi @pmclain, thank you for your contribution! |
@keharper Missing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.3.x
Magento 2.3 related changes
Community
Docs impacted by community code contribution
Major Update
Significant original updates to existing content
Partner: Something Digital
partners-contribution
PR created by Magento partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR adds catalog configuration elements available in the
storeConfig
graphql query. These elements were added in magento/graphql-ce#650Fixes magento/graphql-ce#768
Links to Magento source code
https://github.com/magento/graphql-ce/blob/9f2f5b605564465876b391883be3f19035b5f80a/app/code/Magento/CatalogGraphQl/etc/graphql/di.xml#L83-L97
whatsnew
Added catalog attributes to the storeConfig query in the GraphQL Developer Guide.