Simplify URL resolver #1175
Merged
Simplify URL resolver #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zetlen/upward-add-url-resolver
|
This pull request is automatically deployed with Now. |
tjwiebell
approved these changes
Apr 29, 2019
tjwiebell
added
the
version: Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some conversation with @tjwiebell and others, it's clear that the UPWARD UrlResolver doesn't need to return URL objects as originally specified; it can return URL strings, which satisfies every use case we can think of.
This PR removes the docs, functionality, and tests for that detail.
Related Issue
Closes #1164 .
Revision to #1058 .
Blocks magento/upward-php#64.
Verification Steps
Run
yarn workspace @magento/upward-js test:spec.Checklist: