[Docs] Fix links in Basic Concepts #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalcaben
added
pkg:pwa-devdocs
documentation
|
This pull request is automatically deployed with Now. |
tjwiebell
reviewed
Apr 24, 2019
|
|
||
| For more information, see [Container extensibility]. | ||
| For more information, see [Container extensibility][]. |
There was a problem hiding this comment.
This isn't rendering correctly in Markdown preview, and I'm having issues getting npm run start to run locally. Can you confirm this looks okay in rendered output (and maybe help me resolve my local error 😄 )
| Optimizing the critical path is important to get the best performance out of a progressive web application. | ||
| <sub>[ _[Help write this topic][critical path]_ ]</sub> | ||
|
|
||
| [container extensibility]: {{ site.baseurl }}{%link technologies/basic-concepts/container-extensibility/index.md %} |
There was a problem hiding this comment.
This also doesn't render well, but I'm suspecting is just a markdown preview issue. Help me with my local, and I presume this is good to go.
tjwiebell
approved these changes
Apr 24, 2019
There was a problem hiding this comment.
@jcalcaben helped me get ruby dependencies installed, and rendered output looks perfect. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix links in Basic Concepts topic to just point to the project repo instead of random issues.
Related Issue
Closes #1157
Checklist: