Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XML full form and descriptive link #1139

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented Apr 12, 2019

Description

Added XML full form and descriptive link

Related Issue

Closes #ISSUE_NUMBER.

Verification Steps

https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/bk-frontend-dev-guide.html
https://magento.github.io/glossary/?#8c0645c5-aa6b-4a52-8266-5659a8b9d079

How Have YOU Tested this?

https://magento-research.github.io/pwa-studio/technologies/theme-vs-storefront/

Screenshots / Screen Captures (if appropriate):

http://prntscr.com/naynzz

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@magento-cicd2
Copy link

magento-cicd2 commented Apr 12, 2019

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Apr 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

3 similar comments
@vercel
Copy link

vercel bot commented Apr 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel
Copy link

vercel bot commented Apr 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel
Copy link

vercel bot commented Apr 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍

Please make sure to review and sign the CLA so we can merge your pull request.

@abrarpathan19
Copy link
Contributor Author

@jimbo,
I have sign CLA, please merge my PR

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.914% when pulling 92f418a on abrarpathan19:patch-2 into 9def080 on magento-research:master.

@jimbo
Copy link
Contributor

jimbo commented Apr 17, 2019

@abrarpathan19 In the future, please make sure to open PRs against the develop branch, rather than master. Unfortunately, I've already merged it, so I'll figure out how to revert and get it into develop from here.

jimbo added a commit that referenced this pull request Apr 17, 2019
dpatil-magento pushed a commit that referenced this pull request Jun 26, 2019
…re no results for search (#1252)

* Update index.md (#1139)

* Revert "Update index.md (#1139)"

This reverts commit 8ae1943.

* Disable render suggestion component when search query have not results.

* Cover both items is null or empty array

* Cover changes with tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants