Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off circleci #1132

Merged
merged 4 commits into from
May 3, 2019
Merged

Migrate off circleci #1132

merged 4 commits into from
May 3, 2019

Conversation

sharkySharks
Copy link
Contributor

@sharkySharks sharkySharks commented Apr 10, 2019 •
edited
Loading

Description

This PR is to follow #1087 . After confirming that the AWS CI checks are working as expected, then the follow up is to remove CircleCI configuration and enable blocking checks on the AWS codebuild checks. This PR also removes all CI configuration files from the repository and houses them in a private repository under the magento github organization. The same pr validation checks remain in this repository.

Related Issue

Closes #1131 .

Verification Steps

In this pull request we should see only AWS checks running and passing, once the required checks have been shifted from CircleCI to AWS.

items to check for feature parity with circleci checks working as expected:

  • Coveralls reporting coverage in the comments
  • DangerJS reporting in the comments when there is a failure (I can demo a test failure if needed)
  • BundleSize reporting in the status checks
  • AWS pwa-pr-build passing
  • AWS pws-pr-test passing (which contains all of the checks that CircleCI was performing)

@vercel
Copy link

vercel bot commented Apr 10, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 77.131% when pulling 8cb9bac on migrate-off-circleci into 3cc4deb on develop.

@sharkySharks sharkySharks mentioned this pull request Apr 10, 2019
Merged
jimbo
jimbo reviewed Apr 17, 2019
View reviewed changes
Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also looks good. Let's try to get #1087 merged.

@dpatil-magento dpatil-magento self-assigned this Apr 17, 2019
@vercel vercel bot temporarily deployed to staging April 26, 2019 15:39 Inactive
@zetlen zetlen removed their assignment Apr 26, 2019
@zetlen zetlen merged commit 7189def into develop May 3, 2019
@sirugh sirugh added the tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. label May 24, 2019
@dpatil-magento dpatil-magento deleted the migrate-off-circleci branch July 25, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbo jimbo jimbo left review comments

@zetlen zetlen zetlen approved these changes

Assignees

@dpatil-magento dpatil-magento

Labels
tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs.
Projects
None yet
Milestone
Next PWA Release (Core 2.3.2)
Development

Successfully merging this pull request may close these issues.

Migrate from CircleCI to AWS CI System - Turn off CircleCI
7 participants
@sharkySharks @coveralls @zetlen @jimbo @sirugh @dpatil-magento @cherdman