[dev]: Update eslint config version #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
sirugh
commented
Mar 29, 2019
...venia-concept/src/components/PurchaseHistoryPage/PurchaseHistory/purchaseHistoryContainer.js
Outdated
Show resolved
Hide resolved
jimbo
suggested changes
Apr 1, 2019
...venia-concept/src/components/PurchaseHistoryPage/PurchaseHistory/purchaseHistoryContainer.js
Outdated
Show resolved
Hide resolved
- intlPatches.js updated because it was re-assigning to a const variable - TemplateResolver.js updated so to enforce the prefer-const rule instead of ignoring it - purchaseHistoryContainer.js updated to restore original functionality instead of nested destructuring
|
PR Updated:
|
jimbo
approved these changes
Apr 4, 2019
|
@supernova-at Thanks for taking this over and making those changes. 👍 |
sirugh
added
the
version: Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Updates our magento-eslint config dep to v1.4.0 which adds the
prefer-construle. This rule is fairly straightforward and you can see what it does in the code. That being said there were a few places it did not agree with (array destructuring) so I just ignored those lines.