Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-router-dom to 5.0.0 #1063

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Upgrade react-router-dom to 5.0.0 #1063

merged 2 commits into from
Mar 27, 2019

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Mar 25, 2019 •
edited
Loading

Description

Upgrade react-router-dom dependency from ~4.4.0-beta to ~5.0.0. The major version bump is superficial, because the breaking changes involved were already included in the beta version we're on now.

Related Issue

Closes #1061.

Motivation and Context

  • Move from beta to stable
  • Gain access to hooks

Verification Steps

  • UAT
  • yarn test

How Has This Been Tested?

  • UAT
  • yarn test

@vercel
Copy link

vercel bot commented Mar 25, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@jimbo jimbo requested review from zetlen and sirugh March 25, 2019 22:27
@supernova-at supernova-at self-assigned this Mar 27, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.533% when pulling 70d14b5 on jimbo/react-router-v5 into 48dabc1 on develop.

@supernova-at supernova-at merged commit 7a95721 into develop Mar 27, 2019
@supernova-at supernova-at deleted the jimbo/react-router-v5 branch March 27, 2019 18:44
@sirugh sirugh added the version: Minor This changeset includes functionality added in a backwards compatible manner. label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supernova-at supernova-at supernova-at approved these changes

@zetlen zetlen Awaiting requested review from zetlen

@sirugh sirugh Awaiting requested review from sirugh

Assignees

@supernova-at supernova-at

Labels
version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
Next PWA Release (Core 2.3.2)
Development

Successfully merging this pull request may close these issues.

Upgrade to React Router v5
5 participants
@jimbo @coveralls @supernova-at @sirugh @cherdman