Add unit tests for getOptionType #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
supernova-at
approved these changes
Mar 20, 2019
fnhipster
added a commit
to PMET-public/pwa-studio
that referenced
this pull request
Mar 20, 2019
Add unit tests for getOptionType (magento#1027)
sirugh
added
the
version: Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for
getOptionType.Related Issue
N/A.
Motivation and Context
Even though
getOptionTypeis a private function, and even though its operation is fully covered by its consumers' unit tests, it's good to have more direct coverage.Verification
yarn testHow Has This Been Tested?
yarn test