Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: get_fee and assert_fee_amount to take feerate in sat_vb #69

Open
maflcko opened this issue Feb 7, 2022 · 0 comments
Open

test: get_fee and assert_fee_amount to take feerate in sat_vb #69

maflcko opened this issue Feb 7, 2022 · 0 comments

Comments

@maflcko
Copy link
Owner

maflcko commented Feb 7, 2022

Change the btc_kb argument to sat_per_vb and adjust all call sites.

This allows to remove a lossy truncation via int.

Also, the new argument should be a forced named argument.

Useful skills:

  • Python 3
  • The functional tests
  • Fee rates in BTC/kB and sat/vB

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant