Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't seem to work correctly #2

Closed
phated opened this issue Sep 11, 2022 · 3 comments
Closed

Doesn't seem to work correctly #2

phated opened this issue Sep 11, 2022 · 3 comments

Comments

@phated
Copy link
Contributor

phated commented Sep 11, 2022

I'm trying to implement this as a replacement to cloneable-readable and I don't think this code is working correctly at all.
@phated
Copy link
Contributor Author

phated commented Sep 11, 2022

The failures can be seen via the Vinyl test suite on this PR: gulpjs/vinyl#155

@phated
Copy link
Contributor Author

phated commented Sep 12, 2022

@mafintosh it seems that data is being dropped in 2 tests still. See https://github.com/gulpjs/vinyl/actions/runs/3040224919

@phated
Copy link
Contributor Author

phated commented Sep 23, 2022

Looks to be working now! Thanks 🎉

@phated phated closed this as completed Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phated