Simplify remove

mongo-js · Nov 30, 2015 · 67acfa2 · 67acfa2
1 parent d079280
commit 67acfa2
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/lib/collection.js b/lib/collection.js
@@ -134,18 +134,12 @@ Collection.prototype.remove = function (query, options, cb) {
   this._getCollection(function (err, collection) {
     if (err) return cb(err)
 
-    // TODO: Duplicate code - see xtend below
-    if (options.justOne) {
-      collection.deleteOne(query, xtend(writeOpts, options), function (err, result) {
-        if (err) return cb(err)
-        cb(null, result.result)
-      })
-    } else {
-      collection.deleteMany(query, xtend(writeOpts, options), function (err, result) {
-        if (err) return cb(err)
-        cb(null, result.result)
-      })
-    }
+    var deleteOperation = options.justOne?'deleteOne':'deleteMany';
+
+    collection[deleteOperation](query, xtend(writeOpts, options), function (err, result) {
+      if (err) return cb(err)
+      cb(null, result.result)
+    })
   })
 }