Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Layout Support #30

Closed
AI-IMED opened this issue Apr 16, 2024 · 13 comments · Fixed by #32 or #86
Closed

RTL Layout Support #30

AI-IMED opened this issue Apr 16, 2024 · 13 comments · Fixed by #32 or #86
Assignees
Labels
enhancement New feature or request

Comments

@AI-IMED
Copy link

AI-IMED commented Apr 16, 2024

The application needs to support the layout of RTL languages in the interface as well as the orientation and alignment of RTL languages in text input

SM-N950F_20240416064713.mp4
@maelchiotti maelchiotti self-assigned this Apr 16, 2024
@maelchiotti maelchiotti added the enhancement New feature or request label Apr 16, 2024
@maelchiotti
Copy link
Owner

Hi @AI-IMED, you are right, I will look into it.

@maelchiotti
Copy link
Owner

@AI-IMED I looked into it, and almost all of the app already supports RTL. I only had to fix paddings in #32.

The text field uses fleather which automatically adapts to the language (this is why it's LTR at the beginning of your screen capture, then it switches to RTL as soon as you input some RTL characters).

If you ever wish to localize the app in your language, please feel free to read this!

@maelchiotti maelchiotti linked a pull request Apr 22, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from To do to Done in LocalMaterialNotes Apr 22, 2024
@AI-IMED
Copy link
Author

AI-IMED commented Jun 6, 2024

@maelchiotti
Copy link
Owner

@AI-IMED Hi, I'm sorry but aren't the two things you hilighted already implemented? In the screen capture you itinialy sent, the interface is RTL, and as soon as you input a RTL character into the editor it switches to RTL.

Where exactly do you think I am missing an RTL improvement?

@AI-IMED
Copy link
Author

AI-IMED commented Jun 6, 2024

I didn't notice any changes

@maelchiotti
Copy link
Owner

But I don't understand what exactly you would want me to change

@AI-IMED
Copy link
Author

AI-IMED commented Jun 6, 2024

The bugs that I reported to you and that you told me were fixed and implemented, I did not notice at all

@maelchiotti
Copy link
Owner

Ok, I am pretty sure I tried the app with an RTL language and that they were but to be sure I will try it again.

@maelchiotti maelchiotti reopened this Jun 6, 2024
@maelchiotti maelchiotti moved this from Done to Next release in LocalMaterialNotes Jun 6, 2024
@AI-IMED
Copy link
Author

AI-IMED commented Jun 6, 2024

SM-N950F_20240606095512.mp4

The interface layout and note writing should be just as this app does

@maelchiotti
Copy link
Owner

Ok thanks for the reference

@AI-IMED
Copy link
Author

AI-IMED commented Jun 6, 2024

I am pretty sure I tried the app with an RTL language and that they were

SM-N950F_20240606101906.mp4

@maelchiotti
Copy link
Owner

Oh well it makes that the interface is in LTR mode. Flutter uses the locale of the app to determine if it should set the interface to LTR or RTL. As no RTL languages are supported yet, even if you phone uses a RTL language, the app defaults to English (which of course is LTR).
I don't know if it's possible to force RTL, or even if it would be a desirable option to add into the app.

As for the editor, it should automatically support RTL juste like in the other app you showed, so I will look into it.

@maelchiotti maelchiotti moved this from Next release to In progress in LocalMaterialNotes Jun 7, 2024
@maelchiotti maelchiotti linked a pull request Jun 9, 2024 that will close this issue
@maelchiotti
Copy link
Owner

maelchiotti commented Jun 9, 2024

Hi again @AI-IMED.

  • Regarding the interface: the app was never in RTL mode because it used the locale of the app to determine which mode to use. As no RTL languages are supported (yet), the app falls back to english which is LTR. I modified that in [30] RTL #86 to set the directionality of the app based on the device locale directly, so if your phone does use an RTL language, the app will also be in RTL even if it uses english for the strings.
  • Regarding the editor: The fleather library seems to switch to RTL only if a line begins with an RTL character. To me it looks like a design choice, and a popular one, as I encountered it in Simplenote, Google Keep, Notein... If you believe this should be changed, feel free to create an issue in their repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants