Allow returning `Id` from `extern_methods!` #244

madsmtm · 2022-08-15T13:23:07Z

Initial example syntax:

extern_methods!(
    unsafe impl MyObject {
        #[sel_id(init)]
        fn new() -> Id<Self, Owned>;

        #[sel_id(description)]
        fn get(&self) -> Id<NSString, Owned>;
    }
);

// Becomes
impl MyObject {
    fn new() -> Id<Self, Owned> {
        // Automatic allocation?
        unsafe { msg_send_id![msg_send_id![Self::class(), alloc], init] }
    }

    fn get(&self) -> Id<NSString, Owned> {
        unsafe { msg_send_id![self, description] }
    }
}

To cut down on the amount of code, which should make things easier to review and understand. This uses features which are not actually yet done, see #244. Not happy with the formatting either, but not sure how to fix that?

madsmtm · 2022-11-01T12:15:39Z

I was previously considering allowing init methods to omit the self/this parameter, but I'll probably defer this for now, given that it is a bit of trouble to implement.

To cut down on the amount of code, which should make things easier to review and understand. This uses features which are not actually yet done, see #244. Not happy with the formatting either, but not sure how to fix that?

See full history in 1c4c875. Add initial header translation Closer to usable Mostly works with NSCursor Mostly works with NSAlert.h Refactor a bit AppKit is now parse-able handle reserved keywords Handle protocols somewhat Handle the few remaining entity kinds Works with Foundation Cleanup Refactor Refactor Method to (almost) be PartialEq Parse more things Parse NSConsumed Verify memory management More work Fix reserved keywords Refactor statements Add initial availability Prepare RustType Split RustType up in parse and ToToken part Add icrate Add config files Temporarily disable protocol generation Generate files Add initial generated files for Foundation Skip "index" header Add basic imports Allow skipping methods Properly emit `unsafe` Make classes public Rename objc feature flag Improve imports somewhat Further import improvements Handle basic typedefs Improve generics handling Improve pointers to objects Refactor RustType::TypeDef Mostly support generics Refactor config setup Small fixes Support nested generics Comment out a bit of debug logging Emit all files Parse sized integer types Parse typedefs that map to other typedefs Appease clippy Add `const`-parsing for RustType::Id Parse Objective-C in/out/inout/bycopy/byref/oneway qualifiers Fix `id` being emitted when it actually specifies a protocol Make AppKit work again Parse all qualifiers, in particular lifetime qualifiers More consistent ObjCObjectPointer parsing Validate some lifetime attributes Fix out parameters (except for NSError) Assuming we find a good solution to #277 Refactor Stmt objc declaration parsing Clean up how return types work Refactor property parsing Fixes their order to be the same as in the source file Add support for functions taking NSError as an out parameter Assuming we do #276 Change icrate directory layout Refactor slightly Refactor file handling to allow for multiple frameworks simultaneously Put method output inside an extern_methods! call We'll want this no matter what, since it'll allow us to extend things with availability attributes in the future. Use extern_methods! functionality To cut down on the amount of code, which should make things easier to review and understand. This uses features which are not actually yet done, see #244. Not happy with the formatting either, but not sure how to fix that? Manually fix the formatting of attribute macros in extern_methods! Add AppKit bindings Speed things up by optionally formatting at the end instead Prepare for parsing more than one SDK Specify a minimum deployment target Document SDK situation Parse headers on iOS as well Refactor stmt parsing a bit Remove Stmt::FileImport and Stmt::ItemImport These are not nearly enough to make imports work well anyhow, so I'll rip it out and find a better solution Do preprocessing step explicitly as the first thing Refactor so that file writing is done using plain Display Allows us to vastly improve the speed, as well as allowing us to make the output much prettier wrt. newlines and such in the future (proc_macro2 / quote output is not really meant to be consumed by human eyes) Improve whitespace in generated files and add warning header Don't crash on unions Add initial enum parsing Add initial enum expr parsing Add very simple enum output Fix duplicate enum check Improve enum expr parsing This should make it easier for things to work on 32-bit platforms Add static variable parsing Add a bit of WIP code Add function parsing Fix generic struct generation Make &Class as return type static Trim unnecessary parentheses Fix generics default parameter Remove methods that are both instance and class methods For now, until we can solve this more generally Skip protocols that are also classes Improve imports setups Bump recursion limit Add MacTypes.h type translation Fix int64_t type translation Make statics public Fix init methods Make __inner_extern_class allowing trailing comma in generics Attempt to improve Rust's parsing speed of icrate Custom NSObject TMP import Remove NSProxy Temporarily remove out parameter setup Add struct support Add partial support for "related result types" Refactor typedef parsing a bit Output remaining typedefs Fix Option<Sel> and *mut bool Fix almost all remaining type errors in Foundation Skip statics whoose value we cannot find Fix anonymous enum types Fix AppKit duplicate methods Add CoreData Properly fix imports Add `abstract` keyword Put enum and static declarations behind a macro Add proper IncompleteArray parsing Refactor type parsing Make NSError** handling happen in all the places that it does with Swift Refactor Ty a bit more Make Display for RustType always sound Add support for function pointers Add support for block pointers Add extern functions Emit protocol information We can't parse it yet though, see #250 Make CoreData compile Make AppKit compile Add support for the AuthenticationServices framework Do clang < v13 workarounds without modifying sources Refactor Foundation fixes

madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Aug 15, 2022

madsmtm added this to the objc2 v0.3 milestone Aug 22, 2022

This was referenced Aug 29, 2022

Better class declaration #30

Closed

Define methods in extern_class! macro #161

Closed

This was referenced Oct 31, 2022

Automatic binding generation #264

Closed

Add support for this marking an instance method in extern_methods! #281

Merged

madsmtm added 3 commits November 1, 2022 14:41

Add #[method_id(...)] attribute to extern_methods!

8216c05

Fix duplicate selector extraction

b253482

Use new method_id functionality in Foundation

6aacd14

madsmtm force-pushed the extern-methods-id branch from 8d9d410 to 6aacd14 Compare November 1, 2022 13:42

madsmtm marked this pull request as ready for review November 1, 2022 13:43

madsmtm merged commit 2063dee into master Nov 1, 2022

madsmtm deleted the extern-methods-id branch November 1, 2022 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow returning `Id` from `extern_methods!` #244

Allow returning `Id` from `extern_methods!` #244

madsmtm commented Aug 15, 2022 •

edited

Loading

madsmtm commented Nov 1, 2022

Allow returning Id from extern_methods! #244

Allow returning Id from extern_methods! #244

Conversation

madsmtm commented Aug 15, 2022 • edited Loading

madsmtm commented Nov 1, 2022

Allow returning `Id` from `extern_methods!` #244

Allow returning `Id` from `extern_methods!` #244

madsmtm commented Aug 15, 2022 •

edited

Loading