Small soundness fixes and code cleanup #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pointer was coerced via. `&mut T -> &T` before converting to `*const T` and to `*mut T`, which in the end gives the wrong provenance.
madsmtm
added
bug
2 tasks
madsmtm
force-pushed
the
soundness-fixes
branch
2 times, most recently
from
177cff2
to
17932a6
Compare
Easy to accidentally convert immutable pointers to a mutable ones, as is done in `declare` (now fixed).
Found while experimenting with verification using associated objects in #127.
Hard to see difference between unsafe `&*` and safe Deref, and hard to know whether ptr nullability is handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mutability of pointers when sending a message to
&mut T, the pointer was coerced using&mut T -> &T, which gives the wrong provenance.Fix NSArray::newreturning anOwnedobject - Found while experimenting with verification using associated objects in #127.